Closed asenchi closed 7 years ago
Also /cc @slemiere since this reverts his feature in #33.
Heh just realized that I simultaneously supported 1.8.7 in our parser tests and dropped it for the project as a whole.
@asenchi Nice. Looking forward to this landing
All of this seems reasonable to me and like a step in the right direction. I prefer instantiation.
Now that ruby 1.9.3 is in security fixes only mode I am very excited to get this merged and deployed! Do you need any help or alpha testers for this change?
@asenchi can you give an example of the new single line exception log format?
I will be working to refactor this code since it has sat stale for so long. Apologies for my lax behavior here. I cut a new release with the current behavior here in preparation for this work.
Replaced by #71.
To address #53 this restructures our internal log object. Instead of a module we move to a class that is instantiated upon using
#init
. This breaks current Scrolls behavior in the following ways:global_context
is no longer mutable, instead we instantiate a class internally inside Scrolls::Logger that contains theglobal_context
. This is to avoid various bad thread behaviors, that previous to Ruby 2.0, were allowed.#add_global_context
.Scrolls.init(options)
) however I'd like to work on a method for allowing one to just useScrolls.log
and get sane defaults.#log_exception
without losing the information.I've currently got all tests passing:
I'd like some review on this approach. If the following people wouldn't mind reviewing I would greatly appreciate it: @gorsuch @dpiddy @eric