Closed asenchi closed 7 years ago
This evening I worked to clean up a lot of the refactor, simplify some areas (especially around streams, facilities and structure).
Next I want to bring in any other PRs that existed, make sure they are well tested, appropriate and then work on updating all of the documentation. Then I think this is ready for a proper release.
Alright, I've updated docs, cleaned up the code, added some tests and overall is am ready to merge this and release 0.9.0.
This commit breaks backwards compatibility for Scrolls. It is a rework/refactor of the initial work done in the following PR: https://github.com/asenchi/scrolls/pull/54
#global_context
is no longer mutable, instead we instantiate a class internally inside Scrolls::Logger that contains theglobal_context
. This is to avoid various bad thread behaviors, that previous to Ruby 2.0, were allowed.#add_global_context
.Scrolls.init(options)
) however I'd like to work on a method for allowing one to just useScrolls.log
and get sane defaults.#log_exception
without losing the information.NOTE: I don't have a great setup right now to test everything here. I'm testing against Ruby 2.4.1 and all tests pass. Please test if you can. I'm going to cut a release of this version, 0.9.0.pre. I'm jumping versions here since we break backward compatibility. I'm hopeful with this and subsequent versions we can get to a place where a version 1.0 is a reality.
Please test this version as much as possible!