search

asenchi / scrolls

Simple logging
MIT License
158 stars 26 forks source link

Fix merging log data on nested exception #73

Closed dbussink closed 3 years ago

dbussink commented 3 years ago

This logic was refactored and before the return value of the .merge call was directly used as an argument for the log() call. But since that refactor, it was moved to a separate statement but it means that merging it needs to use merge!.

Without merge! the newly returned hash isn't assigned to any variable and lost, so we lose this in the logging context.

asenchi commented 3 years ago

Great, thank you for the contribution! I'll get a release out in the next day or so with this fix.

dbussink commented 3 years ago

Great, thank you for the contribution! I'll get a release out in the next day or so with this fix.

@asenchi Thanks!