search

asepaprianto / crawler4j

Automatically exported from code.google.com/p/crawler4j
0 stars 0 forks source link

WebCrawler should throw exceptions instead of returning at the middle of the method #322

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This is an internal "refactor" and nothing should be affected externally.

This issue should fix the "flow" of WebCrawler where in several places the 
method stops suddenly as "return" command is called.

This is done for better code readability (although, this is more of a personal 
taste, still most developers prefer one point of exit from a method when it is 
not a guarding clause)

This will also enable better understanding of the code in future planned code 
changes

Original issue reported on code.google.com by avrah...@gmail.com on 9 Dec 2014 at 9:58

GoogleCodeExporter commented 9 years ago 
PageFetcher will be changed accordingly

Original comment by avrah...@gmail.com on 9 Dec 2014 at 10:42

GoogleCodeExporter commented 9 years ago 
Fixed at rev: 511df211f744

Original comment by avrah...@gmail.com on 9 Dec 2014 at 11:00