aseprite / aseprite

Animated sprite editor & pixel art tool (Windows, macOS, Linux)
https://www.aseprite.org
29.42k stars 6.14k forks source link

Wintab crashes #3358

Open dacap opened 2 years ago

dacap commented 2 years ago

A long-standing issue between Aseprite <-> wintab32.dll is all kind of crashes related to the interaction between our code and Wintab implementations. We are not sure if we are using 100% right the API, or if it's related to bugs in Wintab impls, so we aren't sure what to do in these cases.

There is a long history about this: -disable-wintab parameter, then Tablet options, changing to Windows pointer API by default, etc.) A lot of .dmp files received by users manually, and now from Sentry.

Internal Sentry reports:

It looks like these reports are related to a HUION driver mainly. Although the .dll info is anonymous:

Comments: Graphics Tablet Driver, 
CompanyName: Graphics Tablet, 
FileDescription: wintab32 Dynamic Link Library, 
FileVersion: 9, 0, 0, 1, 
InternalName: wintab32, 
LegalCopyright: Copyright (C) 2014, 
OriginalFilename: wintab32.dll, 
ProductName: wintab32 Dynamic Link Library, 
ProductVersion: 9, 0, 0, 1, 

We've received from Sentry the debug info from the wintab32.dll and these are the paths where the .pdb should be located:

D:\V15\trunk\projWin\out\Release\x64\wintab32.pdb
D:\wubo\Code\SvnCode\V15\win\trunk\projWin\out\Release\x64\wintab32.pdb
D:\wubo\Code\SvnCode\drv_win\branch\out\Release\x64\wintab32.pdb

And doing a Google search it looks like the file came from HUION Drivers.

We tried to contact HUION Customer Support, but weren't contacted by their development team, in a near future we might completely disable this wintab32 asking users to report the problem to Huion directly (and forcing Windows API in these cases).

sentry-io[bot] commented 2 years ago

Sentry issue: ASEPRITE-2B

sentry-io[bot] commented 2 years ago

Sentry issue: ASEPRITE-P

dacap commented 2 years ago

The https://sentry.io/organizations/igara-studio/issues/2989300328/ is not related to Wintab, it's a bug from our side, fixed here. The Wacom team help us to identify the issue (we're too used to wintab32.dll bugs, but that one in particular is unrelated).

dacap commented 2 years ago

Probably all these crashes are related to just one specific wintab32.dll of one specific vendor.

{
Comments: Graphics Tablet Driver, 
CompanyName: Graphics Tablet, 
FileDescription: wintab32 Dynamic Link Library, 
FileVersion: 9, 0, 0, 1, 
InternalName: wintab32, 
LegalCopyright: Copyright (C) 2014, 
OriginalFilename: wintab32.dll, 
ProductName: wintab32 Dynamic Link Library, 
ProductVersion: 9, 0, 0, 1
}
dacap commented 1 year ago

Just updated the description as we already know that most of the crashes came from HUION drivers. We might disable them if we don't find other solution (asking the user to update the driver and contact HUION customer support)