Open dacap opened 5 years ago
I'm not 100% sure if we should use uppercase or lowercase in the initial letter of static member functions, e.g.
class System { ... static System* instance(); ... }
orclass System { ... static System* Instance(); ... }
Some changes that must be done for a probable first release of the library (some of these items are implemented in an internal beta version that will be published in the near future):
add Surface::drawText()expand the currentos::draw_text()
function (#12) and remove freetype usage if possible, use Skia directly to draw text,SkShaper
module uses harfbuzz+icuos::Display::setTitleBar()
->setTitle()
os::Surface::bounds()
->Rect(0, 0, width, height)
os::Display::invalidate()
=os::Display->invalidateRegion(display->surface->bounds)
os::ScopedHandle
? addos::DisplayHandle
andos::SurfaceHandle
aliases? or use move semantic and pimpl idiom?os::Display
->os::Window
?os::Display
that is bounds + monitor/screenwe've replaced the parameter with a timeoutgetEvent()
-> replace bool arg with anenum { WaitForEvents, DontWait }
os::Surface::drawSurface()
/blitTo()
in one member function with aos::Paint
argumentk
prefix (e.g.os::Event::ResizeDisplay
vsos::kArrowCursor
; oros::Key::Esc
instead ofos::kKeyEsc
) / Check web KeyboardEvent codes as a reference / #50