search

aseprite / laf

A C++ library to create desktop applications
https://aseprite.github.io/laf/
MIT License
276 stars 60 forks source link

workaround for wintab reporting wrong id length #18

Closed Gnumaru closed 4 years ago

Gnumaru commented 4 years ago

workaround for cases where wintab report the tablet id string length incorrectly

dacap commented 4 years ago

Thanks for your contribution @Gnumaru, I'll merge this on Monday.

Remember that: By submitting a pull request, you represent that you have the right to license your contribution to the Laf project owners and the community, agree by submitting the patch that your contributions are licensed under the Laf license, and agree to future changes to the licensing.

dacap commented 4 years ago

Thank you @Gnumaru, I've just merged your PR, glad to know that you can use your tablet with Aseprite ❤️ This change will be released in a next Aseprite release (probably v1.2.22) but there are no plans in the short term (we would like to wait some other crash report to include in the release).

Gnumaru commented 4 years ago

I'm glad I could contribute with my preferred pixel art editor.

I'm not in a great hurry for the fix. It'll be great to just open it up without hassles, but I'm already "manually" working around the issue by loading wintab only after I launched aseprite, or preferably after I opened the document I'm going to edit. I feel bad for not understanding the inner workings of the crash behavior, but as a programmer, I know there are times when you should just work around the issue and move on =)