search

aseprite / laf

A C++ library to create desktop applications
https://aseprite.github.io/laf/
MIT License
282 stars 61 forks source link

[macOS] Fix searching for SKIA_OPENGL_LIBRARY #20

Closed aesophor closed 4 years ago

aesophor commented 4 years ago

In macOS, if the user's filesystem is case-sensitive, then laf CAN'T locate /System/Library/Frameworks/OpenGL.framework/, which results in link failures. (aseprite/aseprite#1776)

This is because cmake/FindSkia.cmake tries to locate /System/Library/Frameworks/opengl.framework/. (Notice the lowercase "opengl" instead of "OpenGL"), and this commit fixes such error on macOS with a case-sensitive filesystem.

Tested on Macbook Pro Retina 2014 with Mojave + APFS (case-sensitive):

Screen Shot 2020-07-09 at 4 42 53 PM

I agree that my contributions are licensed under the Laf license, and agree to future changes to the licensing.

dacap commented 4 years ago

Hi @aesophor, thanks for the contribution I'll merge this and update laf in the master branch of aseprite 👍

aesophor commented 4 years ago

Thank you! I'm glad that I could contribute to aseprite. 😄