aseprite / laf

A C++ library to create desktop applications
https://aseprite.github.io/laf/
MIT License
276 stars 60 forks source link

base::copy_file implementation #40

Closed doomed-phobos closed 4 months ago

doomed-phobos commented 2 years ago

Hi!

This change, in short, implements base::copy_file function based on the idea of copying and pasting memory blocks. I've also changed the functions (move, copy and delete file) that throw exceptions unnecessarily to return bool type. (It needs clarify that I'm not an expert :sweat_smile:)

dacap commented 1 year ago

Thanks for your contributino @doomed-phobos, at the moment we'd prefer to keep the original behavior of the functions (throwing exceptions).

I'll add some comments to your copy_file implementation just in case if you want to complete it.

dacap commented 4 months ago

Implemented with https://github.com/aseprite/laf/commit/f5ed6fc4dc629e152ff3de42acedfc1c5e601c4b