Fix 'is_process_running' returns an incorrect 'true' when process 'pid' exists, but whose process does not belong to the current application.

aseprite / laf

A C++ library to create desktop applications

https://aseprite.github.io/laf/

MIT License

281 stars 60 forks source link

Fix 'is_process_running' returns an incorrect 'true' when process 'pid' exists, but whose process does not belong to the current application. #75

Closed Gasparoken closed 8 months ago

Gasparoken commented 9 months ago

Windows part not solved yet. Linux not tested yet.

The current fix on all platforms might make aseprite/aseprite#4130 unnecessary.

Gasparoken commented 8 months ago

Ready for review. Linux version without modifications. This fix is needed to fix https://github.com/aseprite/aseprite/issues/4130.

Gasparoken commented 8 months ago

I changed the approach. @martincapello could you please review it again and give me your opinion on the implementation? Could you try again on Linux? This approach works if https://github.com/aseprite/aseprite/pull/4266 is implemented.

Gasparoken commented 8 months ago

@martincapello could you try it one more time?

Gasparoken commented 8 months ago

@dacap the PR is ready for your review.

dacap commented 8 months ago

Merged in:

https://github.com/aseprite/laf/commit/a6c13ab3c349cf76232c7d048afb051cf2a82537 by @Gasparoken
https://github.com/aseprite/laf/commit/4e5249a84900607520de71b6097bde80bbe45469 by @martincapello

I'll see if I change the Windows impl later but the returned value should be the same. With this new get_process_name() function I think the original Aseprite bug could be fixed.