Some sentence problems in 'en.ini'

[TakWolf]

[brush_slot_params]
save_brush = Save Brush Here

Should we need Here?

[brush_slot_params]
save_brush = Save Brush

@66six11

[TakWolf]

[timeline_conf]
first_frame = First Frame:

[options]
default_first_frame = Default First Frame:

Uncertain whether the two have the same function, do we need a unified text?

[TakWolf]

Duplicate shortcut key configuration items:

There's no problem with the strings, it seems like a ui component bug.

Not only the above, there are also many more

[dacap]

Should we need Here?

We could remove the "Here" word, anyway as there are plans to re-design this popup dialog (#175), probably will have a simpler text or just a save icon (or a "Save" tooltip).

Uncertain whether the two have the same function, do we need a unified text?

The "Default First Frame" is for new documents, and the "First Frame" is for the active sprite. Probably we could just use the "First Frame" re-designing the Timeline preferences (related to #1485) with something like Background or Grid sections:

timeline_for_new_docs = Timeline for New Documents
timeline_for_active_doc = Timeline for the Active Document
first_frame = First Frame:

etc.

Duplicate shortcut key configuration items:

I'll try to take a look to this next week.

[TakWolf]

[layer_properties]
luminosity = Luminosity

Is here should be luminance?

---

Update:

Photoshop seems to be using Luminosity

Should we change all luminance to luminosity

sort_by_luminance = Sort by Luminance

---

Update 2:

color_hsl_lightness = Color: HSL Lightness

And I also found a Lightness. Is this should be brightness or luminosity?

[TakWolf]

Not sure, confirmation needed!

[commands]
ToggleOtherLayersOpacity = Toggle Other Layers Opacity
ToggleOtherLayersOpacity_PreviewEditor = Toggle Other Layers Opacity in Preview

Does this mean:

Toggle Other Layers Visibility
Toggle Other Layers Visibility in Preview

---

[commands]
SwitchNonactiveLayersOpacity = Switch Nonactive Layers Opacity

What do Nonactive layers refer to?

[TakWolf]

rewind_on_stop = Rewind on Stop
rewind_on_stop_tooltip = The 'Stop' button should rewind the animation\nwhere it was started.

Does where it was started mean the selected frame?

[TakWolf]

[context_bar]
all_layers = All Layers
current_layer = Current Layer
first_ref_layer = First Reference Layer

Is the description accurate? It may be as follows: (The text is only for illustration purposes)

all_layers = All visible Layers
current_layer = Current Layer （Whether visible or not）
first_ref_layer = All visible Reference Layer

[dacap]

Is here should be luminance?

As you saw, it's Luminosity, it's a standard color blend mode:

https://developer.mozilla.org/en-US/docs/Web/CSS/mix-blend-mode#effect_of_different_mix-blend-mode_values

Should we change all luminance to luminosity

Technically it should be called "luma", which is "relative luminance" with (approximated) gamma-compressed components:

https://en.wikipedia.org/wiki/Luma_(video)#Use_of_relative_luminance

I would prefer to keep Luminance in this case.

And I also found a Lightness. Is this should be brightness or luminosity?

It's Lightness from HSL. It cannot be brightness because it looks like HSV is called Hue/Saturation/Brightness https://en.wikipedia.org/wiki/HSL_and_HSV

Please create one issue for each of these questions, I cannot follow all comments right now and I prefer to answer one per time.

[TakWolf]

@dacap Sorry, I will split the remaining valid issues later