search

aseprite / skia

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.
https://skia.org
BSD 3-Clause "New" or "Revised" License
170 stars 42 forks source link

Should we use python2 in the build instructions? #7

Open dacap opened 4 years ago

dacap commented 4 years ago

Should we use python2 in the build instructions and workflow file?

Related to: https://github.com/aseprite/aseprite/pull/2090

dacap commented 4 years ago

Not sure about this one, on Windows if I use python2 I got this error:

C:\deps\skia>python2 tools/git-sync-deps
'python2' is not recognized as an internal or external command,
operable program or batch file.

While python works correctly.

alvinseptiano commented 4 years ago

so that i was using the wrong version of python? im using ubuntu when im typing python it's using python2 you have to explicitly type python3 to use python3 and i thought it was using python2..

dacap commented 4 years ago

Skia uses/needs python 2. In my previous comment I said that we must use python (it should be pointing to python 2), but we cannot use python2 in the command line because it's not included in the Skia's depot_tools. Just a detail.

ryandesign commented 3 years ago

The aseprite-m81 branch of skia in this repo seems to build fine for me using python 3.9.

ryandesign commented 2 years ago

The aseprite-m81 branch of skia in this repo seems to build fine for me using python 3.9.

I was mistaken; #22 is an example of failure when using python 3.

dacap commented 2 years ago

I think the biggest problem is that depot_tools is a "living thing" where Google updates for new Skia & Chrome, versions. I think they switched to Python 3 recently (but I might be wrong). Probably the best thing to do would be to update Skia to the latest version so it can use the latest depot_tools.