search

aserafin / grape_logging

Request logging for Grape!
MIT License
147 stars 76 forks source link

Add new line to logstash formatter #58

Closed elieteyssedou closed 5 years ago

elieteyssedou commented 5 years ago

Hi,

I think it would be nice to add a new line after each log to the Logstash Formatter, just as the JSON formatter which was recently updated (see: https://github.com/aserafin/grape_logging/pull/52). I need it for my logging.

Thanks

elieteyssedou commented 5 years ago

@aserafin Hi, I am notifying you because you merged the same PR for the JSON formatter recently !

I think it is nice to have this also with the logstash formatter, because it is JSON too. 🙏

elieteyssedou commented 5 years ago

@aserafin up 🙏

iBublik commented 5 years ago

@aserafin Hi, is there something we could do to merge this PR? Currently in our project we use custom formatter which differs from default Logstash formatter only by addition of new line. I think this should be default behaviour.

exosty commented 5 years ago

@aserafin up 🙏

aserafin commented 5 years ago

@elieteyssedou thanks for the contribution, new version 1.8.2 just got released :)