search

aserafin / grape_logging

Request logging for Grape!
MIT License
147 stars 76 forks source link

ActiveSupport::ParameterFilter depends on Rails > 6.0 #64

Closed CodingAnarchy closed 5 years ago

CodingAnarchy commented 5 years ago

The most recent release of grape_logging depends on ActiveSupport::ParameterFilter, which is only compatible with Rails 6.

This broke my Rails 5.2 application upon upgrading. Please update the gemspec to prevent updating past 1.8.1 for Rails 5.2 or modify the code to handle both Rails versions.

mikenichols commented 5 years ago

Just ran into this today. We're on rails 5.1.4 and bumping grape_logging to 1.8.2 breaks our app.

exosty commented 5 years ago

Same for me

aserafin commented 5 years ago

@CodingAnarchy @mikenichols @exosty I've pushed a fix to master but I don't have any app handy to test this. Could you please check and report back?

mikenichols commented 5 years ago

I pulled down the latest 1.8.2 and the problem seems to be resolved. Thanks for taking care of this.

ranjithnalimela commented 5 years ago

@aserafin Could you please create a tag(1.8.3) with latest changes you made on the master branch.

aserafin commented 5 years ago

Tagged and pushed to rubygems - thank you all and @mikenichols especially for the testing 👍

exosty commented 5 years ago

Great! Thank you!