search

aserg-ufmg / RefDiff

A tool to mine refactorings in the commit history of git repositories.
MIT License
148 stars 44 forks source link

Fix the unresolved RefactoringMiner dependency, and ignore the .idea and temp folder. #12

Closed Symbolk closed 3 years ago

Symbolk commented 3 years ago

Thanks for the work. I am recently trying it, and I found several things that can be improved.

  1. The dependency for RefactoringMiner in build.gradle of refdiff-evaluation has been deprecated so cannot be resolved, the available version starts from 2.0 now: https://mvnrepository.com/artifact/com.github.tsantalis/refactoring-miner

  2. Since the API of UMLModelASTReader has changed, if the dependency gets updated, the method should be updated to adapt to it.

  3. The temp folder of cloned repos should be ignored, as well as the .idea for Intellj IDEA users.

Symbolk commented 3 years ago

Here is how I adapted the API for RefactoringMiner 2.0 in my previous project:

image

gqqnbig commented 3 years ago

I can't find out if this PR contains any commits.

An easy way to fix the issue without breaking the code is to download https://github.com/tsantalis/RefactoringMiner/releases/tag/1.0.0 and change this:

// implementation 'org.refactoringminer:RefactoringMiner:1.0'
implementation files('lib/RefactoringMiner/lib/RefactoringMiner.jar')