coveralls
commented
7 hours ago Pull Request Test Coverage Report for Build 11220289365
Details
- 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.006%) to 28.405%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| pkg/app/topaz.go | 0 | 3 | 0.0% | ||
| <!-- | Total: | 0 | 3 | 0.0% | --> |
| Totals | |
|---|---|
| Change from base Build 11147796636: | 0.006% |
| Covered Lines: | 1320 |
| Relevant Lines: | 4647 |
This reverts commit 7a6f2ee154d6905272435fcb0a71d54b14ddc19c.
It was a mistake to omit the "sync" health status when the edge plugin isn't enabled. The plugin can be enabled and disabled dynamically through discovery calls and it's better to always include its status in the health service.
I originally made the change because it looked like the kubernetes startup probe was getting back NOT_SERVING responses, but I tested it again with the change in this PR and the overall pod health is reported as healthy even if the "sync" service's status is NOT_SERVING.