asetalias / amibot

A Whatsapp bot for Amizone. Powered by the go-amizone API
MIT License
25 stars 16 forks source link

Only integral values #22

Closed ObsidianMaximus closed 1 year ago

ObsidianMaximus commented 1 year ago

I think all of us are having integral values as username in amizone, so maybe add a line that will break the operation from going any further if the username is having alphanumeric or string as value?

What do you think sir?

Screenshot_20221003-161504_WhatsApp.png

And if it could say "Invalid Option", then it would look much better.

Screenshot_20221003-161840_WhatsApp.png

Thank you.

ditsuke commented 1 year ago

While numeric usernames is our general observation, it could break since Amizone itself does not guarantee numeric usernames. I'll not block it if you still want to go ahead and implement the validation but it should come with a link to report an issue if the user thinks something is wrong.

ObsidianMaximus commented 1 year ago

I see, well i too think that you are right sir, because maybe some faculty or administrator might be having alphanumeric username.

Your logic is absolutely correct.

ObsidianMaximus commented 1 year ago

Closing as issue has been resolved.