asetalias / amibot

A Whatsapp bot for Amizone. Powered by the go-amizone API
MIT License
25 stars 16 forks source link

Remove unnecessary `options` message #5

Closed ditsuke closed 1 year ago

ditsuke commented 2 years ago

What

The current message flow has a redundant options message:

image

Proposed solution

Instead of the first redundant options message, use only the second list option menu in the flow with an added logout option.

ABHINAV-JHA-27 commented 2 years ago

Hey, I would like to work on the issue. Any guidance as I am a new contributor.

ditsuke commented 2 years ago

Hi @ABHINAV-JHA-27, we lack a mock user at the moment which means you need to be an Amity student to really test the bot. If you're an Amity student or know one or still want to go ahead regardless, I'll be happy to assign the issue to you. As for guidance, the relevant code: https://github.com/ditsuke/amibot/blob/test/states/state_handlers.js#L174. Will be glad to answer any more questions.

rohan09-raj commented 2 years ago

@ditsuke I would like to work on this issue. I am a Amity Student too

ditsuke commented 2 years ago

@ditsuke I would like to work on this issue. I am a Amity Student too

It's yours! :partying_face:

rohan09-raj commented 2 years ago

Let me clear my understanding regarding this issue. What I understood :

ditsuke commented 2 years ago

Let me clear my understanding regarding this issue. What I understood :

  • I need to add an logout option here Current : image Expected : image
  • I need to remove this whole message from the flow. Right ? image

@rohan09-raj exactly, though instead of having logout be a separate button, could we make it another item in the options list? That way the user only has a single button to pop the list out and a logout option at the end of the list.

rohan09-raj commented 2 years ago

@rohan09-raj exactly, though instead of having logout be a separate button, could we make it another item in the options list? That way the user only has a single button to pop the list out and a logout option at the end of the list.

@ditsuke yes, that's a great idea, working on it.