search

asetalias / blog

Welcome to the home of the blog, ALiAS Writes, the land of the free and open-source software.
http://asetalias.in/blog/
Other
11 stars 22 forks source link

Changing the Theme #34

Closed swarnimarun closed 5 years ago

swarnimarun commented 5 years ago

Quick port to the new theme(Massively). It needs some work but it is working.

Any ideas for changes are welcome I tested it with a bit of stuff seems to be a better and more complete theme but has some bugs and problems which need to be fixed.

Also @vipulgupta2048 I would like to have push rights, so that I can quickly merge pull requests(mine and other people's).

vipulgupta2048 commented 5 years ago

Thanks @swarnimarun for the PR, A few screenshots or a link of the deployed blog on GitHub pages would go along better to see how the new changes look and feel. This would facilitate in judging of how the theme change solves previous problems and shortcoming.

The request for push rights has been resolved.

swarnimarun commented 5 years ago

Here are some pics of the theme, image image image

I haven't made any changes to the default posts of the theme because it made more sense to leave it as it is for the moment and make a sample post as a separate PR and as a number of changes need to be made to the theme later.

vipulgupta2048 commented 5 years ago

Thanks, how about mobile accessibility? Loading times? A link would be great instead of screenshots for me to test it out before merging the PR.
Edit: The theme looks great, if only there could be an ALiAS logo on the top. I feel the theme could be tweakable to that extent.

swarnimarun commented 5 years ago

@vipulgupta2048 The link was in the issue I created #33... :unamused:

Anyways, here is the link to the demo site. https://themes.gohugo.io/theme/hugo-theme-massively/ The site loads rather fast, as it's mostly CSS and some jQuery. With the font awesome icons.

Rest of the speed will depend on how optimized images we upload to the GitHub while creating posts.

And adding the Logo is no problem, I can do that whenever we want.

vipulgupta2048 commented 5 years ago

Thanks, @swarnimarun, I was referring to the blog that you created on your fork, and deployment of the same on GitHub pages. I have already seen the theme. Regardless, merging.