blog fixed. :') - Githubissues

asetalias / blog

Welcome to the home of the blog, ALiAS Writes, the land of the free and open-source software.

http://asetalias.in/blog/

Other

11 stars 22 forks source link

blog fixed. :') #74

Closed rohanvtk closed 4 years ago

rohanvtk commented 4 years ago

Please have a look at it. :')

rohanvtk commented 4 years ago

Regarding the first bullet-in I left a comment #71
Secondly, the previous PR had fixes for akshat's blog(images source url was wrong) otherwise, all other changes requested have been implemented.

Sc0rpi0n101 commented 4 years ago

Ok, So, the images have been replaced by links. These look fine in GitHub viewer. But they are not rendering properly on my build. https://sc0rpi0n101.github.io/blog/post/flash_custom_rom/

rohanvtk commented 4 years ago

What should I do now 😕 ?

vipulgupta2048 commented 4 years ago

@Sc0rpi0n101 I think the images aren't working because you installed the @swarnimarun new theme version for testing & now we have another problem of images breaking. We need to investigate this.

rohanvtk commented 4 years ago

@vipulgupta2048 so will these images show up on the main website if someone merges this PR(I won't 😛)?

Sc0rpi0n101 commented 4 years ago

At this point bro, only the Lord knows what'll happen if someone merges anything 🤣🤣

vipulgupta2048 commented 4 years ago

+10 on that and then a +100 on Hugo being dark magic.

I actually checked out this great blogging framework folks were working in React India, https://shaaijs.tech

Sc0rpi0n101 commented 4 years ago

Alright, now that everything's fixed merging this now :rocket: