search

asetalias / blog

Welcome to the home of the blog, ALiAS Writes, the land of the free and open-source software.
http://asetalias.in/blog/
Other
11 stars 22 forks source link

Refresh theme, travis etc.. #76

Closed swarnimarun closed 4 years ago

swarnimarun commented 4 years ago

Update for hugov0.60 and above.

swarnimarun commented 4 years ago

cc: @Sc0rpi0n101 @vipulgupta2048

Sc0rpi0n101 commented 4 years ago

Are you missing some commits? I only see the one removing the theme.

Are we replacing it with another one? and how is the site rendered after the changes?

swarnimarun commented 4 years ago

Aah oops seems like I didn't push somethings. LoL

vipulgupta2048 commented 4 years ago

Mini Discussion

Would it be a better decision to keep a submodule in the repo and not download the theme? I have been reading about the best practices regarding submodules in git and the last sections of this article make pretty good points https://github.blog/2016-02-01-working-with-submodules/#advice-on-using-submodules-or-not

TL:DR

  1. Wouldn't it be better if we lock down the SHA (Commit) of the module down to a specific commit so that it is the same for all contributors in .gitmodules?
  2. Every time a new person comes to the repo, he/she needs to run a. Clone the repo recursively, b. Make sure to update the submodule c. Also, make sure the constantly updating submodule doesn't break anything in the theme of the blog.
  3. I feel most contributors would forget and later would leave overhead for us or the CI to solve when PR's are being made in the long term. (I have 3 submodules in my own dotvfiles, and I forget to recursively clone the repo from personal experience. Just removed all of them in the December update)
swarnimarun commented 4 years ago

@vipulgupta2048 1- I have already locked it to 3.3-stable branch which is supposed to be locked to a stable commit with patch fixes allowed. 2- technically we can just add a simple .sh file to the repo that can be run instead of installing hugo and all that, auto setup process to start with development. 3- vendoring is a lot more of a problem as it's the most easily breaking part of the workflow so submodules would always be the better choice as for VCS.

swarnimarun commented 4 years ago

EDIT::: OOPSIE I haven't locked this one, I thought I had locked to the latest build release. LoL

I will lock it to the latest tag/commit release ASAP.

Sc0rpi0n101 commented 4 years ago

@swarnimarun How long is this going to take?

swarnimarun commented 4 years ago

oooof it was already at the latest stable for this remote. There was no change to be committed or pushed apparently... LOL I got confused due to diffing against multiple remote....

Sc0rpi0n101 commented 4 years ago

Transformation failed: TOCSS: failed to transform "main.scss" (text/x-scss): this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information

This is the error log for the Travis build @swarnimarun

swarnimarun commented 4 years ago

image

Sc0rpi0n101 commented 4 years ago

BTW we made changes to the theme to customize it for our blog https://github.com/asetalias/blog/pull/37

The social links are generic links to the site, the footer is wrong and The ALiAS writes logo is not there, ... etc. So, those need to be fixed xD.

Sc0rpi0n101 commented 4 years ago

@swarnimarun

Sc0rpi0n101 commented 4 years ago

@swarnimarun @vipulgupta2048 I have modified the theme as per the blog at https://github.com/Sc0rpi0n101/hugo-theme-massively The local build looks fine. Can you guys check too?

image

image

vipulgupta2048 commented 4 years ago

Can you post the GitHub pages link for it as well

Sc0rpi0n101 commented 4 years ago

Can you post the GitHub pages link for it as well

https://sc0rpi0n101.github.io/blog_build/

vipulgupta2048 commented 4 years ago

The ALiAS logo image is crunched up. Can you fix that! I can't go into any of the blogs, because of the mangled paths and that's okay.

vipulgupta2048 commented 4 years ago

Let's also get this finished or merge when ready. We should be using the AMA blog has our Outreach tool. Need to update that with the Whatsapp link

Sc0rpi0n101 commented 4 years ago

@vipulgupta2048 Can you check it now? Does the logo look alright now?

I think we can merge after that is fixed.

vipulgupta2048 commented 4 years ago

LGTM

On Sun, Mar 8, 2020 at 4:20 PM Nikhil Maan notifications@github.com wrote:

@Sc0rpi0n101 commented on this pull request.

In .travis.yml https://github.com/asetalias/blog/pull/76#discussion_r389357222:

install:

⬇️ Suggested change

In .travis.yml https://github.com/asetalias/blog/pull/76#discussion_r389357321:

install:

⬇️ Suggested change

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/asetalias/blog/pull/76?email_source=notifications&email_token=AFN63HXPOI6IFWG7D2UAZRLRGN2ADA5CNFSM4J77UKE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYNEMKA#pullrequestreview-370820648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFN63HQVG35AALGXKC3NFA3RGN2ADANCNFSM4J77UKEQ .

-- Best, Vipul Gupta Mixster https://mixstersite.wordpress.com/ | Github https://github.com/vipulgupta2048

Sc0rpi0n101 commented 4 years ago

@swarnimarun ping

swarnimarun commented 4 years ago

Added the commits with cc. Anything else important?

Sc0rpi0n101 commented 4 years ago

I don't think so.

Can we merge this or is there anything else left to fix?

Sc0rpi0n101 commented 4 years ago

@vipulgupta2048 @swarnimarun

swarnimarun commented 4 years ago

Alright had a minute did a review of the old code. Fixed the travis. And didn't find any more issues so feel free to push.

Sc0rpi0n101 commented 4 years ago

Alright, merging it now.

Hope it doesn't blow up in our face :rofl: