search

asfadmin / ASF_MapReady

GNU General Public License v3.0
37 stars 21 forks source link

Fixed compilation failures related to usage of type bool #481

Closed ikselven closed 5 years ago

ikselven commented 7 years ago

Using gcc 6.3 on Debian 9 (Stretch), compilation fails because:

  1. in struct anomaly_t in src/asf_meta/propagate.h there is a field labelled "true"
  2. in include/ifm.h the type definition for bool is problematic

This pull request fixes these problems by:

  1. renaming the field "true" to "isTrue"
  2. replacing the custom boolean type definition with stdbool.h which provides a type bool
ikselven commented 6 years ago

Is there something that still needs to be done to get this PR closer to being merged?

I've noticed, that the first commit in this PR has become obsolete with the removal of the offending struct anomaly_t in 0a0c542.

Leaving that aside, without the other commits in this PR (9c1fae9, c64f1fa) , it is still impossible to compile ASF MapReady with gcc on Debian Stretch. (gcc 6.3.0, Debian 9.5)

ikselven commented 5 years ago

Closing this now in favor of a cleaner, new PR.

csallen2 commented 5 years ago

Still in favor of more cowbell...

Cougar

On Wed, Mar 20, 2019 at 4:08 AM Felix Glaser notifications@github.com wrote:

Closing this now in favor of a cleaner, new PR.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/asfadmin/ASF_MapReady/pull/481#issuecomment-474785042, or mute the thread https://github.com/notifications/unsubscribe-auth/AFcsO_3dBm3dPHwKOZe6O0LNPKVG9QIKks5vYhaUgaJpZM4OanOX .

-- Clay Allen University of Alaska Fairbanks 907-699-8878