asfadmin / Discovery-asf_search

BSD 3-Clause "New" or "Revised" License
126 stars 43 forks source link

ASFProduct Subclassing #225

Closed SpicyGarlicAlbacoreRoll closed 7 months ago

SpicyGarlicAlbacoreRoll commented 12 months ago

Breaks platform/processing level specific fields and aliases into subclasses, removes several non-common fields from base ASFProduct class.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (a5f017e) 89.79% compared to head (19ec81f) 89.73%.

Files Patch % Lines
asf_search/ASFSearchResults.py 27.77% 13 Missing :warning:
asf_search/Products/S1BURSTProduct.py 88.23% 4 Missing :warning:
asf_search/Products/ARIAS1GUNWProduct.py 82.35% 3 Missing :warning:
asf_search/Products/OPERAS1Product.py 92.10% 3 Missing :warning:
asf_search/export/jsonlite.py 72.72% 3 Missing :warning:
asf_search/ASFProduct.py 97.75% 2 Missing :warning:
asf_search/Products/AIRSARProduct.py 81.81% 2 Missing :warning:
asf_search/Products/SEASATProduct.py 80.00% 2 Missing :warning:
asf_search/ASFStackableProduct.py 97.50% 1 Missing :warning:
asf_search/Products/JERSProduct.py 92.30% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #225 +/- ## ========================================== - Coverage 89.79% 89.73% -0.06% ========================================== Files 54 69 +15 Lines 2028 2299 +271 ========================================== + Hits 1821 2063 +242 - Misses 207 236 +29 ``` | [Flag](https://app.codecov.io/gh/asfadmin/Discovery-asf_search/pull/225/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/asfadmin/Discovery-asf_search/pull/225/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin) | `89.73% <92.87%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB