asfadmin / Discovery-asf_search

BSD 3-Clause "New" or "Revised" License
126 stars 43 forks source link

S1 Baseline Stacking Fix #236

Closed SpicyGarlicAlbacoreRoll closed 10 months ago

SpicyGarlicAlbacoreRoll commented 10 months ago

Inconsistency between datetime.timestamp() across systems causes timestamp() to infer different timezones for date objects. Baseline calculations depends on these values, and when certain product baseline values lacked the timezone indicator it'd lead to bad baseline values depending on the system environment.

Solution:

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5f9ff0b) 89.83% compared to head (0dfa6df) 89.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #236 +/- ## ========================================== + Coverage 89.83% 89.86% +0.03% ========================================== Files 53 53 Lines 1987 1994 +7 ========================================== + Hits 1785 1792 +7 Misses 202 202 ``` | [Flag](https://app.codecov.io/gh/asfadmin/Discovery-asf_search/pull/236/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/asfadmin/Discovery-asf_search/pull/236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin) | `89.86% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.