asfadmin / Discovery-asf_search

BSD 3-Clause "New" or "Revised" License
126 stars 43 forks source link

[BUGFIX] Params marked as Iterable now actualy support Iterables #251

Closed SpicyGarlicAlbacoreRoll closed 8 months ago

SpicyGarlicAlbacoreRoll commented 8 months ago

Parameters marked as supporting iterables actually only supported lists. Instances of List and checks for list instances now changed to support Iterables

codecov-commenter commented 8 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a2fc3c4) 89.85% compared to head (3eff6dd) 89.85%.

Files Patch % Lines
asf_search/ASFSearchOptions/validators.py 73.91% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #251 +/- ## ======================================= Coverage 89.85% 89.85% ======================================= Files 54 54 Lines 2021 2021 ======================================= Hits 1816 1816 Misses 205 205 ``` | [Flag](https://app.codecov.io/gh/asfadmin/Discovery-asf_search/pull/251/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/asfadmin/Discovery-asf_search/pull/251/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin) | `89.85% <73.91%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.