search

asfadmin / Discovery-asf_search

BSD 3-Clause "New" or "Revised" License
124 stars 43 forks source link

Adds subproduct class type casting to baseline_search #256

Closed SpicyGarlicAlbacoreRoll closed 7 months ago

SpicyGarlicAlbacoreRoll commented 7 months ago
review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov-commenter commented 7 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (19ec81f) 89.73% compared to head (8e4c6b2) 89.60%.

Files Patch % Lines
asf_search/search/baseline_search.py 62.50% 6 Missing :warning:
asf_search/Products/ARIAS1GUNWProduct.py 62.50% 3 Missing :warning:
asf_search/Products/OPERAS1Product.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## topic-ASFProduct-subclassing #256 +/- ## ================================================================ - Coverage 89.73% 89.60% -0.14% ================================================================ Files 69 69 Lines 2299 2318 +19 ================================================================ + Hits 2063 2077 +14 - Misses 236 241 +5 ``` | [Flag](https://app.codecov.io/gh/asfadmin/Discovery-asf_search/pull/256/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/asfadmin/Discovery-asf_search/pull/256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin) | `89.60% <69.44%> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=asfadmin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.