search

asfaltboy / SublimeTestPlier

run python tests quickly from within a project
https://packagecontrol.io/packages/Test%20Plier
MIT License
10 stars 4 forks source link

Can I use shell_cmd instead of cmd? #24

Open evandrocoan opened 5 years ago

evandrocoan commented 5 years ago

I tried using shell_cmd instead of cmd, but TestPlier did not filled the things.

https://www.sublimetext.com/docs/3/build_systems.html

asfaltboy commented 5 years ago

That's a neat idea, I've noticed your commit, do you mind opening a PR, and allowing me to commit to the PR to re-style your code a bit?

asfaltboy commented 5 years ago

In fact I noticed your fork has a bunch of changes, which of these do you feel should make their way into "upstream"?

evandrocoan commented 5 years ago

My fork has an well tested feature to remember the selected unit test, I removed your unit tests because I could not get they working or understand them, and as renamed your python_test_plier.py to test_plier.py because python was too redundant for me, and finally, git is not allowing to cherry pick the commit due the file rename.

asfaltboy commented 5 years ago

Oh sorry, I forgot that you opened PR #22 (starting to show my age now). I personally feel the last test selection in that branch is too invasive. I would instead make it a separate command (e.g "rerun last test"), so that it can be rerun as many times as needed without considering function name at all.

I kept python_test_plier as the name of the plugin module to not confuse the module with a "test_X.py" test module. When cherry-pick fails me, I just copy paste the code pieces from the diff like a caveman!

Please feel free to submit more PRs, and I'll try to guide as best as I can about failing tests and how to write new ones. This will help me greatly reduce the code-rot in this package, as it ages together with me 🙈 !

evandrocoan commented 5 years ago

The new pull request I just opened still have the commits I did when trying to make your Unit Tests to work:

image

evandrocoan commented 5 years ago

I would instead make it a separate command (e.g "rerun last test"), so that it can be rerun as many times as needed without considering function name at all.

I would not use another command because there are enough commands already. Anyways, there is a setting which control whether this feature is enabled or not.