asfernandes / node-firebird-drivers

Node.js Firebird Drivers
MIT License
54 stars 17 forks source link

Add method for query cancellation #136

Closed tom4zelli closed 1 year ago

tom4zelli commented 1 year ago

Permitir o uso de cancelOperation, expondo diretamente na interface Attachment.

asfernandes commented 1 year ago

The driver should better avoid recreating weirdness of Firebird interfaces, so it would be better to split the function in two:

tom4zelli commented 1 year ago

Ok, could it be something like this?

cancelOperationEnable/cancelEnable(value:boolean)

tom4zelli commented 1 year ago

Captura de tela de 2023-02-25 10-14-56

asfernandes commented 1 year ago

Can you write tests for it? Also, please follow the coding style using spaces appropriately, example: no var?1:2 but var ? 1 : 2

tom4zelli commented 1 year ago

ok, sorry, my first contribution with git projects, I'm not yet familiar with norms and patterns...

asfernandes commented 1 year ago

I did some rework in your solution in branch https://github.com/asfernandes/node-firebird-drivers/tree/work/cancellation Please review and test.

tom4zelli commented 1 year ago

Tested and it's ok!!!

tom4zelli commented 1 year ago

thanks!!!, can you guide me if i should do anything else? I need to finalize something, should I do a "close pull request"?

asfernandes commented 1 year ago

thanks!!!, can you guide me if i should do anything else? I need to finalize something, should I do a "close pull request"?

Please maintain the PR open for now, it should change automatically to merge when I merge the branch I created with your commits included.

asfernandes commented 1 year ago

Merged in master.