Closed tom4zelli closed 1 year ago
The driver should better avoid recreating weirdness of Firebird interfaces, so it would be better to split the function in two:
Ok, could it be something like this?
cancelOperationEnable/cancelEnable(value:boolean)
Can you write tests for it?
Also, please follow the coding style using spaces appropriately, example: no var?1:2
but var ? 1 : 2
ok, sorry, my first contribution with git projects, I'm not yet familiar with norms and patterns...
I did some rework in your solution in branch https://github.com/asfernandes/node-firebird-drivers/tree/work/cancellation Please review and test.
Tested and it's ok!!!
thanks!!!, can you guide me if i should do anything else? I need to finalize something, should I do a "close pull request"?
thanks!!!, can you guide me if i should do anything else? I need to finalize something, should I do a "close pull request"?
Please maintain the PR open for now, it should change automatically to merge when I merge the branch I created with your commits included.
Merged in master.
Permitir o uso de cancelOperation, expondo diretamente na interface Attachment.