search

asg017 / dataflow

An experimental self-hosted Observable notebook editor, with support for FileAttachments, Secrets, custom standard libraries, and more!
https://alexgarcia.xyz/dataflow/
MIT License
400 stars 24 forks source link

Upgrade Observable Standard Library to latest #33

Closed harrislapiroff closed 3 years ago

harrislapiroff commented 3 years ago

I noticed it was outdated when I tried to use the new FileAttachment.sqlite() functionality. This seems to fix it!

harrislapiroff commented 3 years ago

@asg017 Any chance of seeing this merged? It's quite a small PR, I swear!

asg017 commented 3 years ago

Hey @harrislapiroff thanks for the PR and for the reminder!

When you tried this fix, were you able to actually use .sqlite() on a file attachment? I ask because I tried to update dataflow to the most recent observablehq version of the runtime, stdlib, and inspector, but ran into issues with .sqlite()

For some reason, .sqlite() for normal file attachments were erroring with ".sqlite is not a function", and when I fixed that, I was getting Error: database disk image is malformed when querying, and SQLiteDatabaseClient is not defined when trying to use that new builtin.

Nonetheless, I think I know the issue, and I hope to fix+release a new dataflow version with updated observablehq deps this weekend!

harrislapiroff commented 3 years ago

@asg017, no, you're correct, I didn't end up successfully using .sqlite(), but I figured having the standard library update was good anyway 😅

Looking forward to the fix!

daniel-james-sherwood commented 3 years ago

The corruption is due to the attachment being read with utf8 encoding which results in various bytes being replaced. !34 should fix that

asg017 commented 3 years ago

Thank you @daniel-james-sherwood for that PR! The standard library and runtime for dataflow is now up-to-date with the latest version. SQLite File Attachments now work with dataflow! Did it in another PR bc had to make a few other fixes. Will close this PR, but thank you @harrislapiroff and @daniel-james-sherwood for bringing this up!

Available in v0.0.11. You can upgrade with npm i -g @alex.garcia/dataflow@v0.0.11

daniel-james-sherwood commented 3 years ago

Alex

That's ok. I only found it because I was trying to use zip files which had similar corruption.

Now you have updated the stdlib I can just use the zip stuff that comes with it.

Daniel

On Fri, 22 Oct 2021, 07:37 Alex Garcia, @.***> wrote:

Thank you @daniel-james-sherwood https://github.com/daniel-james-sherwood for that PR! The standard library and runtime for dataflow is now up-to-date with the latest version. SQLite File Attachments now work with dataflow! Did it in another PR bc had to make a few other fixes. Will close this PR, but thank you @harrislapiroff https://github.com/harrislapiroff and @daniel-james-sherwood https://github.com/daniel-james-sherwood for bringing this up!

Available in v0.0.11. You can upgrade with npm i -g @@.***

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/asg017/dataflow/pull/33#issuecomment-949329146, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDY7H5U4XMGQBKZUA4DYITUIEBC3ANCNFSM5CNNVOCA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.