asg017 / sqlite-regex

A fast regular expression SQLite extension, written in Rust
Apache License 2.0
166 stars 7 forks source link

Add install support via sqlpkg? #16

Open mikeschinkel opened 7 months ago

mikeschinkel commented 7 months ago

I know you provide competitive comparison with sqlean, but his pkgsql is a really nice tool to manage sqlite3 extensions so I am wondering if you can add install support to allow his tool to manage updates for your extension?

When I tried sqlpkg install asg017/sqlite-regex I got the following:

> installing asg017/sqlite-regex...
! failed to read package spec: asg017/sqlite-regex: open asg017/sqlite-regex: no such file or directory
https://github.com/asg017/sqlite-regex/raw/main/sqlpkg.json: got http status 404
https://github.com/nalgeon/sqlpkg/raw/main/pkg/asg017/sqlite-regex.json: got http status 404

Seems as easy as adding a sqlpkg.json to your repo?

It also seems you already did so for hello?

asg017 commented 7 months ago

That's odd, it seems like it's already a part of the sqlpkg registry: https://github.com/nalgeon/sqlpkg/blob/main/pkg/asg017/regex.json

Maybe sqlpkg install asg017/regex works?

mikeschinkel commented 7 months ago

Ah, yes it did.

I had tried sqlpkg install asg017/sqlite-regex from your repo URL.

Maybe updating the README.md is all that's needed? I'm too tired this minute or would do a PR.

mikeschinkel commented 7 months ago

So I added an update on #17 to README.md as I implied I would.