asg017 / sqlite-vss

A SQLite extension for efficient vector search, based on Faiss!
MIT License
1.59k stars 58 forks source link

support on disk indices #90

Closed dleviminzi closed 10 months ago

dleviminzi commented 11 months ago

Adds support for storing faiss indices on disk.

Todo:

asg017 commented 10 months ago

Quick update here: I intend to merge this, but found some errors while testing. The TL;DR is that the parse_constructor() function is quite buggy, mostly because I wrote it with raw string parsing, which isn't great.

So I'm writing a new tokenizer + parser for the parse_constuctor() function, which really cleans up the code, and will make it much easier to add new options in the future. Once I finish it, I'll probably merge this PR first, apply my changes, then make a new release this weekend

dleviminzi commented 10 months ago

Quick update here: I intend to merge this, but found some errors while testing. The TL;DR is that the parse_constructor() function is quite buggy, mostly because I wrote it with raw string parsing, which isn't great.

So I'm writing a new tokenizer + parser for the parse_constuctor() function, which really cleans up the code, and will make it much easier to add new options in the future. Once I finish it, I'll probably merge this PR first, apply my changes, then make a new release this weekend

Sounds good (I will add mmap option when new parser is in)

asg017 commented 10 months ago

Merging into main, then will make some more edits + tests on top of that.

Let's move the discussion to #4