Closed dleviminzi closed 10 months ago
Quick update here: I intend to merge this, but found some errors while testing. The TL;DR is that the parse_constructor()
function is quite buggy, mostly because I wrote it with raw string parsing, which isn't great.
So I'm writing a new tokenizer + parser for the parse_constuctor()
function, which really cleans up the code, and will make it much easier to add new options in the future. Once I finish it, I'll probably merge this PR first, apply my changes, then make a new release this weekend
Quick update here: I intend to merge this, but found some errors while testing. The TL;DR is that the
parse_constructor()
function is quite buggy, mostly because I wrote it with raw string parsing, which isn't great.So I'm writing a new tokenizer + parser for the
parse_constuctor()
function, which really cleans up the code, and will make it much easier to add new options in the future. Once I finish it, I'll probably merge this PR first, apply my changes, then make a new release this weekend
Sounds good (I will add mmap option when new parser is in)
Merging into main, then will make some more edits + tests on top of that.
Let's move the discussion to #4
Adds support for storing faiss indices on disk.
Todo:
storage_type
instead ofon_disk