[BUG] Missing `faiss::FaissException` in the compile procedure

asg017 / sqlite-vss

A SQLite extension for efficient vector search, based on Faiss!

MIT License

1.59k stars 58 forks source link

[BUG] Missing `faiss::FaissException` in the compile procedure #93

Open yfyang86 opened 10 months ago

yfyang86 commented 10 months ago

[BUG] Missing faiss::FaissException in the compile procedure

FAISS Version: Current master as 2023-08-16 faiss
sqlite-vss Version: Current master

Behavior:

Error message

no type named 'FaissException' in namespace 'faiss'

Fix, add the <faiss/impl/FaissException.h> file to sqlite-vss.cpp:

...
#include <random>

#include <faiss/impl/FaissException.h>
#include <faiss/IndexFlat.h>
#include <faiss/IndexIVFPQ.h>
#include <faiss/impl/AuxIndexStructures.h>
...

asg017 commented 10 months ago

If you checkout the submodules in the sqlite-vss repo, it points to the facebookresearch/faiss@868e17f29493075742170885f1f57c7b9e61d9ea , which is pretty old. We can bump this to something newer (at least v1.7.4, Apr 19th ), where we can update the #includes to fix errors like this.

But if you're compiling sqlite-vss yourself, I recommend checking out the submodules in that repo, since we haven't tested on newer version of Faiss.