API calls has to be consistent - Githubissues

asgardeo-samples / asgardeo-enterprise-ciam-sample

An enterprise use case sample that captures the overall CIAM story that utilize Asgardeo and Choreo.

Apache License 2.0

0 stars 2 forks source link

API calls has to be consistent #4

Closed ashendes closed 1 year ago

ashendes commented 1 year ago

Description:

[x] In some components of the webapps, HTTP requests are defined within the component [1],[2]. These should be moved to a separate API/service layer. There are several other instances in addition to those mentioned that need to be identified and addressed.
[x] API requests related to different components/APIs should be added in separate files.

[1] https://github.com/asgardeo-samples/asgardeo-enterprise-ciam-sample/blob/2b7d6ce25108080d4bfd3f48b4e4699f0c5b568a/src/apps/kfone-customer-support/src/pages/marketing/index.tsx#L105 [2] https://github.com/asgardeo-samples/asgardeo-enterprise-ciam-sample/blob/2b7d6ce25108080d4bfd3f48b4e4699f0c5b568a/src/apps/kfone-customer-support/src/pages/marketing/index.tsx#L72