search

asgardeo-samples / asgardeo-enterprise-ciam-sample

An enterprise use case sample that captures the overall CIAM story that utilize Asgardeo and Choreo.
Apache License 2.0
0 stars 2 forks source link

Move all configurable values to the configuration file #8

Closed ashendes closed 1 year ago

ashendes commented 1 year ago

Description: Certain values have been hardcoded to the apps. These should be changed to accept values from the .env environment variables (or atleast made optional, if the value is unlikely to change).

[1] https://github.com/asgardeo-samples/asgardeo-enterprise-ciam-sample/blob/2b7d6ce25108080d4bfd3f48b4e4699f0c5b568a/src/apps/kfone-website/src/api/index.js#L134 [2] https://github.com/asgardeo-samples/asgardeo-enterprise-ciam-sample/blob/2b7d6ce25108080d4bfd3f48b4e4699f0c5b568a/src/apps/kfone-website/src/api/index.js#L134