Custom Params passed to the Authorize request are getting moderated by the SDK. - Githubissues

asgardeo / asgardeo-auth-react-sdk

To maintain the implementation of Asgardeo React authentication SDK

Apache License 2.0

40 stars 91 forks source link

Custom Params passed to the Authorize request are getting moderated by the SDK. #208

Closed brionmario closed 11 months ago

brionmario commented 11 months ago

Describe the issue:

The following set of params are passed into the signIn hook.

const authParams = {};

authParams["fidp"] = "OrganizationSSO";
authParams["orgId"] = getOrganizationName();

await signIn(authParams);

And the SDK transforms the keys in to Snake Case which causes issues.

Screenshot 2023-12-20 at 17 10 36

This change seems to have been introduced with https://github.com/asgardeo/asgardeo-auth-js-core/pull/203/files#diff-f34c1fc70c8dfe6982556af3ab69b70a42b7a68c9119cfa0bfa4716acd929750R120.

How to reproduce:

Pass the above set of custom params to the signIn hook.

Expected behavior:

SDK should not transform the keys.

Environment information (Please complete the following information; remove any unnecessary fields) :

Product Version: IS 7.0 BETA 4
OS: Mac
Database: H2
Userstore: LDAP

brionmario commented 11 months ago

Fixed in @asgardeo/auth-js and propagated to @asgardeo/auth-spa & @asgardeo/auth-react.

@asgardeo/auth-js: https://github.com/asgardeo/asgardeo-auth-js-core/pull/249
@asgardeo/auth-spa: https://github.com/asgardeo/asgardeo-auth-spa-sdk/pull/161
@asgardeo/auth-react: https://github.com/asgardeo/asgardeo-auth-react-sdk/pull/209