Closed s-vamshi closed 1 month ago
Hey @NipuniBhagya @pavinduLakshan done with the changes
@NipuniBhagya can you please review this now made the changes
Hi @s-vamshi,
While .npmignore
seems like a viable option to overcome the issue, i think we can resolve this with a simple files
entry in the package.json
.
Have you considered that option?
IMO, since we don't go into granular level to which files in include, rather we can just simply include dist
, package.json
, README
, better to go for the files
option.
Additionally, we could also copy the LICENSE
file at the root to the lib
folder, and include that as well in the distribution.
WDYT?
Hey @brionmario, I agree with you, as lib folder didn't have .gitignore I thought of going with .npmignore.
I will add files section in package.json and push them!
Hey @brionmario, I agree with you, as lib folder didn't have .gitignore I thought of going with .npmignore.
I will add files section in package.json and push them!
Cool 🙌
Lets duplicate the LICENSE
inside lib
and include that as well :)
Sure 🚀
hey @brionmario, done with changes
Hey @brionmario @NipuniBhagya @pavinduLakshan I have made the changes as suggested can you please review this PR?
Hey @brionmario @NipuniBhagya @pavinduLakshan can you please review this PR?
LGTM too. Merged!
🚢 Shipped with v5.2.0
Thanks @s-vamshi for the contribution 🎉
Looks like the fix is working as expected. If time permits, please try the released version in a React app and do a regression test round!
Thanks @s-vamshi for the contribution. This just reduced the package size by 10% (744KB -> 659KB). Great work!
Thanks @s-vamshi for the contribution 🎉
Looks like the fix is working as expected. If time permits, please try the released version in a React app and do a regression test round!
Sure I will do regression testing
Hi @s-vamshi,
🎉 Thank you for your contribution! 🎉
We appreciate your effort and the time you've taken to submit this PR. As part of the Hacktoberfest process, please make sure to fill out the form [1] shared to ensure we can properly track your contribution.
Once again, thank you for your support, and we're excited to have you involved in our project! 🙌
Purpose
Resolves #200
Goals
src folder shouldn't be added in package and compiled types should be inside dist/types
Approach
Added .npmignore file to ignore src and added decelerationDir key in tsconfig.json to put complied types in dist/types/src