asgardex / asgard-exchange

https://app.asgard.exchange
30 stars 8 forks source link

Executing Swaps above set slippage tolerance #107

Closed bagh0dler closed 3 years ago

bagh0dler commented 3 years ago

Hello,

i am experiencing slippage above the set tolerance. There is 1) no warning that the slippage exceeds the set tolerance and 2) i am able to execute anyway.

Regards

Set Tolerance: image

Swap 1/2: image

Swap 2/2: image

Transaction: https://testnet-explorer.binance.org/tx/8BD65E3ECEF7214C37827EC9B2A6BDE0DAF45D41040390C06A0C6B660A307DC3

stuartwk commented 3 years ago

@bagh0dler nice catch. PR #109 disables the swap button if the slip exceeds the limit.