asgerf / bracket-rename

Rename refactoring for bracket
MIT License
14 stars 2 forks source link

Will be broken by Sprint 35 ModalBar change #3

Closed peterflynn closed 10 years ago

peterflynn commented 10 years ago

In the next release of Brackets, we're simplifying ModalBar a bit to eliminate the Enter key handling and "commit" event. It appears that your extension relies on this functionality.

It should be relatively simple to add your own enter key handling, something like this:

modalBar.getRoot().keydown(function (event) {
    if (event.keyCode === 13) {
        modalBar.close();
        // ... do whatever your "commit" handler used to do ...
    }
});

If you bump up the version requirement in your package.json, people with older versions of Brackets will still be able to install the older version of your extension that uses the "commit" event instead.

peterflynn commented 10 years ago

@asgerf Btw, I also notice your extension metadata is missing the homepage property to link back to your repo on GitHub. It's useful to have that -- Extension Manager exposes it as a "More info..." link. Here's an example of how to set it up in package.json.

asgerf commented 10 years ago

Thanks for the heads up.

I tried the latest Brackets from github, following instructions on this page but the extension still seems to work in that setting.

I will take a look at this once Sprint 35 is released, so I have a reliable way of testing my code.

peterflynn commented 10 years ago

@asgerf You won't see it on master yet but you can see the changes on this branch.

asgerf commented 10 years ago

Ah, thanks. It should be forward compatible now.