search

asgerf / parsejs.dart

JavaScript parser for Dart
BSD 2-Clause "Simplified" License
26 stars 11 forks source link

TODO: Combining Spacing Mark (Mc) is missing from unicode. #1

Closed mezoni closed 9 years ago

mezoni commented 9 years ago

parsejs/lexer.dart

bool isFancyNamePart(x) => x == char.ZWNJ || x == char.ZWJ || x == char.BOM || unicode.isNonspacingMark(x); // TODO: Combining Spacing Mark (Mc) is missing from unicode.

Combining Spacing Mark (Mc) in unicode called as a SPACING_MARK.

unicode/unicode.dart

const int SPACING_MARK = 10;
bool isSpacingMark(int character) => spacingMarkCharacters[character];

According to unicode/tool/generate.dart

static const Categories MC = const Categories("Mc", "SPACING_MARK", 10);
asgerf commented 9 years ago

Ah, thanks. That explains why I couldn't find it the first time.

asgerf commented 9 years ago

Fixed in 1.0.2.