search

asgiom / cr8-brm-mobile-issues

0 stars 1 forks source link

[BUG] Change pin #100

Closed ibanezvaio closed 4 years ago

ibanezvaio commented 4 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to Settings
    • ensure biometric is enabled
  2. Click on [Change Pin]
  3. Enter the requested details (email, new pin, pin confirmation)
  4. Tap [Change Pin]<- app is slow to respond here. I had to keep tapping [Change Pin] for it to respond
  5. When biometric is requested, ensure this fails
  6. See screenshot with "Enter PIN to authorise PIN modification"
  7. Cancel button does not work here
  8. Closing and reopening the app does not resolve the issue as Biometric fails
  9. Only way to get access again is uninstalling and recovering the wallet from Seed words

PIN modification I assume happening in the background. It appears that biometric correlates to the Pin and when the change is requested, the Pin is changed but not authorised in step 3 above, leaving the app in an orphaned state.

Expected behavior No modification should occur until biometric is authorised

Screenshots image0 (2)

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

t3nshi commented 4 years ago

Yes, it seems that this is not really the bug but the same behavior you reported earlier when the biometric gets cancelled. #90 another thing is that this is not going to behave well when we have biometrics enabled since biometrics disable the pin. So I will look into only providing this option with biometrics disabled

danielwwf commented 4 years ago

Not fixed :(

t3nshi commented 4 years ago

can you provide details? did you tested on v 0.5.5 ? what happened and on what device? we checked by the steps provided on ios device and simulator and with the fix for handling the error it was resolved.

ibanezvaio commented 4 years ago

My bad, I’ve updated the original description for a better understanding. There was a critical step missing that i couldn’t capture ( I was locked out because of the bug).

Tested in 0.5.5 @t3nshi

t3nshi commented 4 years ago

thanks for making the steps more precise... I will make sure to test with this steps again to reproduce the error. Again, I think we should only allow changing the PIN when you already disabled the biometrics... but let's check this out.

ibanezvaio commented 4 years ago

Pin change is only allowed to occur when biometrics is disabled. Fixed in 0.5.6