search

asgiom / cr8-brm-mobile-issues

0 stars 1 forks source link

SHARE ACCOUNT QR CODE GENERATED LINKS TO CASINOCOIN.COM #116

Open georgemac70cr8 opened 4 years ago

georgemac70cr8 commented 4 years ago

ONCE AGAIN, THIS IS VITALLY IMPORTANT THAT WE DO NOT CONNECT 2 SEPARATE BRANDS. CASINOCOIN FOUNDATION CANNOT BE ASSOCIATED WITH CRAZY8TOKEN.

ANDROID APK 5.6 VERSION:

When the share account feature is used, it generates a scannable QR code. When scanned this qr code produces a casincoin.com url, rather than a deep link.

To Reproduce RECEIVE > SHARE ACCOUNT share to tg, slack, whatsapp, etc

please scan the QR CODE TO recreate.

(in addition, sometimes the qr code is 'true size' and sometimes it is smaller / in the corner. I'll atatched screenshots.

Expected behavior Please make sure the deep link is corrected and corresponds tot he correct QR code. Please make siure it doesn't link to casinocoin url.

PLEASE MAKE SURE THIS IS TESTED BY AT LEAST ONE PERSON WITH AN ANDROID PHONE BEFORE SENDING BACK TO MATT, DANIEL OR GEORGE TO TEST.

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information): ANDROID 10, HUAWEI P20 PRO

SCREENSHOTS

THE QR CODE DOESN'T 'FILL' THE AREA WHEN SHARED - IT TAKES UP A CORNER. photo_2020-09-22 16 24 39

WRONG URL photo_2020-09-22 16 24 29

AFTER REFRESHING QR CODE AND THEN RESHARING, IT SHARES A LARGER QR CODE IMAGE photo_2020-09-22 16 24 17

LINKING TO CASINOCOIN REAL ESTATE photo_2020-09-22 16 24 09

Additional context Add any other context about the problem here.

t3nshi commented 4 years ago

this was not supposed to be added to this version because of this issue... well, so I will have it fixed for next version. Basically it helped me realize that upon resharing the image is fixed... I will try to figure it out.

t3nshi commented 4 years ago

Well I need to clarify this now so we decide ahead. There is no deep link and the QR has not ever had that functionality, what the QR provides is the means to share information quickly among wallets. We are including functionality from the CasinoCoin wallet that is publicly available... and this is for enabling the QR Code to share a label, the destination tag and amount. That way we can use the CR8 wallet to grab a QR and be ready to send with amount, destination tag and account id already loaded. Further more, we can use a CSC wallet and be ready to send CR8 with that same QR, either from desktop, mobile or the CSC BRM. We could just put the address (AccountID) there as plain text... and discard the use of the enhancements for sharing additional information that provides the implementation of the CSC wallet. Another thing we could do is to deliver our specific implementation that would be only compatible with Crazy8Token, but won't operate on a CSC Wallet. That way the URI (this is what is called that string and it stands for Uniform Resource Identifier, it is not a link, nor a Deep Link) will have the Crazy8Token.com, but it will need some work to be ready and have the additional information ready, and if we would like to be able to use those QRs and use the additional info on the CSC wallet, we would need to make an array of many other changes on that functions on the CSC wallets. So there it is. Before deciding, please wait until you test how it works (when it is fixed) on the wallet... So you can decide which route we should go.