asgiom / cr8-brm-mobile-issues

0 stars 1 forks source link

[REQUEST]Remove all CSC related assets #129

Closed danielwwf closed 4 years ago

danielwwf commented 4 years ago

Remove all CSC related assets -> cr8-brm-mobile/src/assets/, replace with CR8 related assets.

There should not be a single graphic related to CSC anywhere

t3nshi commented 4 years ago

What are you talking about... If this is a bug please make it reproducible so we can test and figure it out... Otherwise with something so general and unespecific I won't be able to address it or even validate solution... Thanks.

danielwwf commented 4 years ago

Check the source code as mentioned above, we cant test the app day in day out just to find another CSC asset as they are still there.

Just check ALL assets and if they are CSC related, REMOVE them. Have a look at cr8-brm-mobile/src/assets/ its full of BRM graphics

t3nshi commented 4 years ago

This is on which app version.

Mattch33 commented 4 years ago

image

t3nshi commented 4 years ago

I saw it on the original issue... for the future it will be quicker to just reference the issue like this #128

Mattch33 commented 4 years ago

I don't think we should go down the route of discussing speed. Please do as requested.

t3nshi commented 4 years ago

I'm sorry. I was only trying to be helpful but clearly I wasn't.

georgemac70cr8 commented 4 years ago

this has now been corrected but let's just make sure it is still correct on 0.5.8

t3nshi commented 4 years ago

this was validated by several users already, only issue was still with testflight users, as it seems that there was a caching of icons from previous versions. But in it was reported on #128 that it was only a little buggy on testflight on 0.5.8 but it was resolved. It is very functional both on 0.5.8 and 0.5.9. So I will be closing this now.