Closed georgemac70cr8 closed 4 years ago
ok. we will include it in next release.
Did someone had a chance to check this?
yes, it doesn't look great. Can you split the lines so there's approx equal numbner of chars per line?
also the 'additional information' doesn't look like a link
So I removed white space as you requested, but let me add a bit of padding and the additional information could be a button maybe so it stands out as a CTA...
it's more the split of the sentence... you have much more chars on line 1 than you do on line 2:
PLEASE NOTE: if you would like to sell back your CR8, you must do so (69 chars) within 7 days of purchase (25 chars)
please compare my screenshot to yours
[cid:92e5f232-9038-476f-9547-f0ab1768fa12]
From: TeNsHi SaMa notifications@github.com Sent: 15 September 2020 18:59 To: asgiom/cr8-brm-mobile-issues cr8-brm-mobile-issues@noreply.github.com Cc: georgemac70cr8 georgemcgeorge@hotmail.com; Author author@noreply.github.com Subject: Re: [asgiom/cr8-brm-mobile-issues] [UI-FIX] additional text needed and layout change for buy/sell section (#82)
So I removed white space as you requested, but let me add a bit of padding and the additional information could be a button maybe so it stands out as a CTA... [Screenshot 2020-09-15 at 11 53 47]https://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F3123415%2F93241344-d5831680-f74a-11ea-8dc2-677739afc79c.png&data=02%7C01%7C%7Cb9f3c31e96f54320bd2808d85998b42b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637357859670143907&sdata=r0zzMZrH8%2Fh1NLMDmYIrNm6Xnsn1DwJ3WJjSlqRXYwI%3D&reserved=0
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fasgiom%2Fcr8-brm-mobile-issues%2Fissues%2F82%23issuecomment-692845539&data=02%7C01%7C%7Cb9f3c31e96f54320bd2808d85998b42b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637357859670153904&sdata=Xmrsel1ylpVvzop%2BXSlZQ6ntVygqN3uUTVzT1WgxmWc%3D&reserved=0, or unsubscribehttps://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQUW4GNY3YK2SCDDBRIQ2RDSF6MO3ANCNFSM4REZ7XTA&data=02%7C01%7C%7Cb9f3c31e96f54320bd2808d85998b42b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637357859670153904&sdata=cYXxJMJ6a3bFDKzo5MaLO2Jzvgz7rwl2FJciJTvNppk%3D&reserved=0.
This is not a reliable way to make a change... since this is not going to fit the same way on different screens widths
take a look so you get the idea
i don't have the answers but i just don't know why you choose to have 69 chars on one line and 25 on another - you don't need to answer. Please just do whatever looks best, i can leave to your discretion and judgement thanks.
how about like this...
yes, that looks much better thanks. Now i see what you're saying now with regards to screen size.
that's what I meant.... the screen is the one that decides about the chars.. I have no control about it... I just say let's make the text this big and aligned center or left... and it gets placed depending on the device screen size
thank you, additional info button looks better - but can we move the button under the other 2 buttons - we don't want to distract from people making their buy.
Please can you just add a "." (full stop) a the end of the sentence. Then good to go. Thanks
Ok done. We will check on next version.
fixed
Section or interface element BUY/SELL SECTION
Reason We need to add some text to explain that people only have 7 days to sell back their cr8 that they buy in the app.
Description Please add the following text: "PLEASE NOTE: if you would like to sell back any CR8, you must do so within 7 days of purchase." - in orange text colour and centered.
and below the "I want to buy..." text box.
The "I want to buy " text box needs to be moved up higher in the form.
Screenshots Illustrate current look and feel. Or provide commented pictures, or edited screens to see how it should look like. Be clear about which picture is edited