search

asgiom / cr8-brm-mobile-issues

0 stars 1 forks source link

[BUG] cancelling login causes ANR #90

Closed ibanezvaio closed 4 years ago

ibanezvaio commented 4 years ago

To Reproduce Steps to reproduce the behavior:

  1. Open the app
  2. If you have biometric login, ensure this fails (I was using faceID)
  3. Tap cancel when asked to try again
  4. App is seemingly in ANR state. Login and restore buttons are unresponsive

Expected behavior Login button should produce biometric or pin entry

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

t3nshi commented 4 years ago

the problem also seems to happen if you just cancel the biometric request, even on android... this seems related to #89 and in android we can get away by just pressing the back button. It seems that the issue is related to fallback methods that should be provided by the OS... but I will find a way to overcome this kind of behaviour.

ibanezvaio commented 4 years ago

I need an iOS build to test this one

ibanezvaio commented 4 years ago

I can replicate in 0.5.4, iOS

danielwwf commented 4 years ago

On my Note8 the app gets very laggy when biometric is activated, there is also no way to use the pin instead.

Mattch33 commented 4 years ago

Also causes a lot of lag on Android S9. Managed to log in but bio metric area remained. Only fix was restarting phone. Screenshot_20200916-112902_CR8 Wallet

t3nshi commented 4 years ago

I will try to test on some samsungs so we can sort this out.

Mattch33 commented 4 years ago

Great stuff,

Thank You

Matt

From: TeNsHi SaMa [mailto:notifications@github.com] Sent: 17 September 2020 12:46 To: asgiom/cr8-brm-mobile-issues cr8-brm-mobile-issues@noreply.github.com Cc: Mattch33 matthew@crazy8token.com; Comment comment@noreply.github.com Subject: Re: [asgiom/cr8-brm-mobile-issues] [BUG] cancelling login causes ANR (#90)

I will try to test on some samsungs so we can sort this out.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/asgiom/cr8-brm-mobile-issues/issues/90#issuecomment-694177362 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APXJKPK5LLGXHYH7RVCPY53SGHZIPANCNFSM4RIFPYZQ . https://github.com/notifications/beacon/APXJKPPHXEXKJQLNN4W2SK3SGHZIPA5CNFSM4RIFPYZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFFQE4UQ.gif

t3nshi commented 4 years ago

Since we need to wait for App store to test this... I would move this to the next version

ibanezvaio commented 4 years ago

I can still replicate this in 0.5.6

t3nshi commented 4 years ago

Ok, I thought the fix was enough, any difference when you tested this on 0.5.6, or it behaves exactly the same?

ibanezvaio commented 4 years ago

Seems to behave exactly the same. No difference

t-jacobi commented 4 years ago

Couldn't reproduce the behavior. iOS 13.6.1, iPhone 6s, App 0.5.8

t3nshi commented 4 years ago

You mean it is fixed? if it is can you close it? if it isn can you please elaborate?

ibanezvaio commented 4 years ago

I can’t replicate this one in 0.5.9. Closing