beroso
commented
6 years ago Travis CI build is failing because of this check:
'100' => ['100', 1.0], // @todo this is weird behaviour, should not really expect this
Could you check if it is suitable?
Open beroso opened 6 years ago
beroso
commented
6 years ago Travis CI build is failing because of this check:
'100' => ['100', 1.0], // @todo this is weird behaviour, should not really expect this
Could you check if it is suitable?
asgrim
commented
6 years ago At the moment, can't merge this as it would be a BC break (hence why that test case exists). Yes, it's stupid behaviour but some may rely on it, unfortunately so I can't change until next major release. Otherwise, will review this in time, but as it's a BC break don't hold your breath ;)
beroso
commented
6 years ago Understood. What are your plans to the next release? I will be glad to help
asgrim
commented
6 years ago Currently, to find time to refactor for better quality, more tests, fix the stupid things that don't make sense and make a minimum PHP 7.1 or 7.2 probably :+1:
Fix #19