asgsaeid / ComboLoss

MIT License
19 stars 5 forks source link

dice term question #2

Closed shinel94 closed 4 years ago

shinel94 commented 4 years ago

in combo_loss.py, line 20, code is combo = (ce_d_w weighted_ce) - ((1 - ce_d_w) (1 - d)) but last term also combo so i think that become plus or only d not 1-d I hope to know about your opinion

asgsaeid commented 4 years ago

this was due to rewriting the function here; either (a - b) or a + (1-b) works; now code reflects the function in the paper