search

ash-jc-allen / favicon-fetcher

A Laravel package for fetching favicons from websites.
MIT License
173 stars 13 forks source link

keep port if available #50

Closed mhoffmann777 closed 1 year ago

mhoffmann777 commented 1 year ago

I have some Docker services running on a host that use different ports. To get the favicon from all services, the fetcher needs to keep the specified port for all URLs.

BTW: This is my very first contribution to a repo ever. :)

ash-jc-allen commented 1 year ago

Hey @mhoffmann777! First of all, congrats on making your first contribution 😄

Would it be possible for you to write a test(s) for this new functionality? I'd love to see an example of where this might be used 🙂

mhoffmann777 commented 1 year ago

Hey, hope this simple test will do it :)

ash-jc-allen commented 1 year ago

Perfect! Thanks for that, I appreciate it 😄

I made a slight tweak to the code, and added a test (that I probably should have added myself a while ago). I'll get that merged in now and hopefully released over the weekend or early next week!