ash-jc-allen / favicon-fetcher

A Laravel package for fetching favicons from websites.
MIT License
167 stars 13 forks source link

Migrate to `symfony/dom-crawler` #56

Closed ash-jc-allen closed 1 year ago

ash-jc-allen commented 1 year ago

Up until now, the HttpDriver has used some regex and pattern-matching that I wrote myself to try and extract the links from the HTML. They've worked most of the time, but it's starting to become a bit more difficult to catch every use case.

This PR proposes requiring symfony/dom-crawler and using that to grab the favicons when using the HttpDriver. In theory, any devs using Favicon Fetcher shouldn't notice any difference.

I'll be checking this over the next day or two to make sure the migration will go as smoothly as possible 😄

ash-jc-allen commented 1 year ago

This PR also includes 2 small bug fixes that were spotted when doing this migration: