ash-jc-allen / laravel-exchange-rates

A Laravel wrapper package for interacting with the exchangeratesapi.io API.
MIT License
449 stars 49 forks source link

Update exchangerate.host driver to match new API #148

Closed ash-jc-allen closed 1 year ago

ash-jc-allen commented 1 year ago

The exchangerate.host API service was recently updated (seemingly without warning) and put behind a paywall. As part of the updates, all requests now require an API key to be passed as a query parameter. The endpoints, accepted query parameters, and response structure have also all been updated.

This PR makes some updates to the package so that we can interact with the newer version of this API.

Breaking change?

I'm not entirely sure whether this is a breaking change or not 🤔

This change will require human intervention (adding the API key to the .env file) which leads me to think it'd be a major version bump.

However, this fix is needed due to an external change and anyone using this package won't be able to interact with this API at the moment. So I think this means it can be treated as a bug fix (patch version bump) rather than a breaking change (major version bump).