search

ash-jc-allen / short-url

A Laravel package for creating shortened URLs for your web apps.
MIT License
1.27k stars 162 forks source link

Refactor code #175

Closed datlechin closed 1 year ago

datlechin commented 1 year ago
ash-jc-allen commented 1 year ago

Hey @datlechin, thanks for the PR!

Unfortunately, I'm going to close the PR because there are a lot of unrelated changes that have been made at once without any explanation for why. So it makes it difficult to review it all at once. I think I'm happy with the current state of the code, so I don't think any of these changes are needed.

But if you feel that any of them should be included in the package, I'd be happy to review smaller PRs (that target one change) that have an explanation for why the changes have been made.

Thanks for taking the time to try and improve the package, I appreciate it! 😄